Skip to content

Removed custom version of AtmosphereSigmaFactory in diagnostics#2405

Merged
schlunma merged 1 commit intomainfrom
remove_atmosphere_sigma_coordinate
Nov 3, 2021
Merged

Removed custom version of AtmosphereSigmaFactory in diagnostics#2405
schlunma merged 1 commit intomainfrom
remove_atmosphere_sigma_coordinate

Conversation

@schlunma
Copy link
Contributor

@schlunma schlunma commented Nov 3, 2021 •
edited
Loading

Description

This PR removes the custom version of AtmosphereSigmaFactory in all affected diagnostics.

Corresponding PR in the core: ESMValGroup/ESMValCore#1382

Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic

To help with the number of pull requests:

@schlunma schlunma added the iris label Nov 3, 2021
@schlunma schlunma self-assigned this Nov 3, 2021
@schlunma schlunma mentioned this pull request Nov 3, 2021
Closed
@schlunma schlunma marked this pull request as ready for review November 3, 2021 14:24
@schlunma schlunma added this to the [locked] v2.4.0 milestone Nov 3, 2021
valeriupredoi
valeriupredoi approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers @schlunma 👍

@valeriupredoi
Copy link
Contributor

valeriupredoi commented Nov 3, 2021

@esmvalbot please run recipe_ecs_constraints.yml

@esmvalbot
Copy link

esmvalbot bot commented Nov 3, 2021

Since @valeriupredoi asked, ESMValBot will run recipe recipe_ecs_constraints.yml as soon as possible, output will be generated here

@schlunma
Copy link
Contributor Author

schlunma commented Nov 3, 2021

@esmvalbot please run recipe_ecs_constraints.yml

Does the bot use the current main of ESMValCore? If not this will fail 😬

@valeriupredoi
Copy link
Contributor

valeriupredoi commented Nov 3, 2021

sure it will, but I thought this bit of the diag will go through? Ignore the run if I'm wrong

@remi-kazeroni
Copy link
Contributor

remi-kazeroni commented Nov 3, 2021

@esmvalbot please run recipe_ecs_constraints.yml

Does the bot use the current main of ESMValCore? If not this will fail 😬

Yes it does. The bot does not install the Core in dev mode, just the Tool. Let's wait for the outcome of this run before merging this.

@schlunma
Copy link
Contributor Author

schlunma commented Nov 3, 2021

It needs the changes in the core (in particular the changed fixes for some models) to work, so it will only work with the current main of ESMValCore. I tested the recipes recipe_ecs_constraints.yml and recipe_schlund20esd.yml locally, both run fine now! 🎉

@esmvalbot
Copy link

esmvalbot bot commented Nov 3, 2021

ESMValBot is sorry to report it failed to run recipe recipe_ecs_constraints.yml: exit is 1, output has been generated here

@valeriupredoi
Copy link
Contributor

valeriupredoi commented Nov 3, 2021

well the bot pulled a fast one and surprised us by not finding data - not even close to running the diagnostic 😆 Merge at will by me 👍

@schlunma schlunma merged commit 8f136e9 into main Nov 3, 2021
@schlunma schlunma deleted the remove_atmosphere_sigma_coordinate branch November 3, 2021 16:54
@remi-kazeroni
Copy link
Contributor

remi-kazeroni commented Nov 3, 2021

In my previous attempt to run this recipe (see #1380), the same file was missing and automatically downloaded. For reference, the automatic download option has not yet been enabled for the bot due to a lack of disk space on that VM.

@valeriupredoi
Copy link
Contributor

valeriupredoi commented Nov 3, 2021

cheers @remi-kazeroni - safer that way 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@valeriupredoi valeriupredoi valeriupredoi approved these changes

@remi-kazeroni remi-kazeroni Awaiting requested review from remi-kazeroni

Assignees

@schlunma schlunma

Labels

diagnostic iris

Projects

None yet

Milestone

[locked] v2.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@schlunma @valeriupredoi @remi-kazeroni